Conversation
Add test scripts and infrastructure for validating all PF tasks, including: - Basic CDP import validation - Generator functionality testing - Type checking verification - Documentation build testing
|
Resolves #62 |
|
To provide feedback, I recommend leaving inline comments for best results. Navigate to the Files changed tab and leave comments on the proposed code changes. Choose Start review for each comment, and then choose Request changes, and I'll propose revised changes. If creating PR-level comments, include as much detail as possible in your feedback (for example, file name, class name, line number). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # Change to workspace | ||
| os.chdir('/workspace') | ||
|
|
||
| # Read and parse the .pf file | ||
| pf_file = Path('.pf') |
There was a problem hiding this comment.
The PF task scanner changes into /workspace and then looks for .pf in that directory, but the repository (and the .pf file it needs to read) lives under /workspace/python-chrome-devtools-protocol. Running this script from the repo root will always log “.pf file not found” and return early, so none of the PF tasks are exercised unless the project is manually relocated to /workspace.
Useful? React with 👍 / 👎.
1 participant
This pull request implements comprehensive testing infrastructure for PF tasks in the CDP (Chrome DevTools Protocol) Python library. The key changes include:
The changes aim to ensure reliable execution of all PF tasks and provide better visibility into test failures and system status. This enhances the development workflow and helps maintain code quality.